search

kubernetes-retired / poseidon

[EOL] A Firmament-based Kubernetes scheduler
http://www.firmament.io
Apache License 2.0
410 stars 79 forks source link

Add spelling check script and fix typos #142

Closed islinwb closed 6 years ago

islinwb commented 6 years ago

/assign @m1093782566

m1093782566 commented 6 years ago 
W1012 07:26:55.525] can't load package: package k8s.io/kubernetes/vendor/github.com/client9/misspell/cmd/misspell: cannot find package "k8s.io/kubernetes/vendor/github.com/client9/misspell/cmd/misspell" in any of:
W1012 07:26:55.526]     /usr/local/go/src/k8s.io/kubernetes/vendor/github.com/client9/misspell/cmd/misspell (from $GOROOT)
W1012 07:26:55.526]     /go/src/k8s.io/kubernetes/vendor/github.com/client9/misspell/cmd/misspell (from $GOPATH)
islinwb commented 6 years ago

/test ci-poseidon-e2e-gce

m1093782566 commented 6 years ago

/retest

islinwb commented 6 years ago

/hold Let me fix the failed test first...

m1093782566 commented 6 years ago

Error logs of test:

I1015 03:21:07.530] +++ [1015 03:21:07] Creating data container kube-build-data-6bae5ecc2a-5-v1.9.3-1
I1015 03:21:18.250] +++ [1015 03:21:18] Syncing sources to container
I1015 03:21:26.381] +++ [1015 03:21:26] Running build command...
I1015 03:21:27.206] Skipping generated files....
I1015 03:21:27.710] +++ [1015 03:21:27] Building the toolchain targets:
I1015 03:21:27.711]     github.com/kubernetes-sigs/poseidon/vendor/k8s.io/kubernetes/hack/cmd/teststale
I1015 03:21:27.767] Makefile:92: recipe for target 'all' failed
I1015 03:21:27.770] Makefile:442: recipe for target 'cross' failed
W1015 03:21:27.870] can't load package: package github.com/kubernetes-sigs/poseidon/vendor/k8s.io/kubernetes/hack/cmd/teststale: cannot find package "github.com/kubernetes-sigs/poseidon/vendor/k8s.io/kubernetes/hack/cmd/teststale" in any of:
W1015 03:21:27.871]     /usr/local/go/src/github.com/kubernetes-sigs/poseidon/vendor/k8s.io/kubernetes/hack/cmd/teststale (from $GOROOT)
W1015 03:21:27.871]     /go/src/github.com/kubernetes-sigs/poseidon/_output/dockerized/go/src/github.com/kubernetes-sigs/poseidon/vendor/k8s.io/kubernetes/hack/cmd/teststale (from $GOPATH)
W1015 03:21:27.871] !!! [1015 03:21:27] Call tree:
W1015 03:21:27.871] !!! [1015 03:21:27]  1: /go/src/github.com/kubernetes-sigs/poseidon/hack/lib/golang.sh:616 kube::golang::build_kube_toolchain(...)
W1015 03:21:27.871] !!! [1015 03:21:27]  2: hack/make-rules/build.sh:27 kube::golang::build_binaries(...)
W1015 03:21:27.871] !!! [1015 03:21:27] Call tree:
W1015 03:21:27.871] !!! [1015 03:21:27]  1: hack/make-rules/build.sh:27 kube::golang::build_binaries(...)
W1015 03:21:27.871] make[1]: *** [all] Error 1
W1015 03:21:27.872] make: *** [cross] Error 1
W1015 03:21:27.991] !!! [1015 03:21:27] Call tree:
W1015 03:21:27.993] !!! [1015 03:21:27]  1: build/../build/common.sh:551 kube::build::run_build_command_ex(...)
W1015 03:21:27.995] !!! [1015 03:21:27]  2: build/release.sh:36 kube::build::run_build_command(...)
W1015 03:21:27.996] make: *** [quick-release] Error 1
m1093782566 commented 6 years ago

/retest

hope #143 can help the tests pass.

shivramsrivastava commented 6 years ago

/lgtm

Thanks @islinwb and @m1093782566

islinwb commented 6 years ago

/hold cancel

m1093782566 commented 6 years ago

/approve

k8s-ci-robot commented 6 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: islinwb, m1093782566

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/poseidon/blob/master/OWNERS)~~ [m1093782566] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment