search

kubernetes-retired / poseidon

[EOL] A Firmament-based Kubernetes scheduler
http://www.firmament.io
Apache License 2.0
410 stars 78 forks source link

Adding a flag to enable/disable success events from Poseidon #163

Closed shivramsrivastava closed 5 years ago

shivramsrivastava commented 5 years ago

This PR provides a flag to disable the success events. By setting the below flag one can disable the success events from being sent to the k8s.

--disableEvents=true

By success events we mean the happy case were a pod gets assigned to a node, if a pod cannot be assigned to a node an warning/failure event will be sent.

k8s-ci-robot commented 5 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: shivramsrivastava

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/poseidon/blob/master/OWNERS)~~ [shivramsrivastava] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
k8s-ci-robot commented 5 years ago

Hi @shivramsrivastava. Thanks for your PR.

I'm waiting for a kubernetes-sigs or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
m1093782566 commented 5 years ago

/ok-to-test

m1093782566 commented 5 years ago

@shivramsrivastava

I am curious to learn the user case where we need this feature?

shivramsrivastava commented 5 years ago

@m1093782566 we added this flag to disable the success events during benchmarking and see the results. Specially when we have pod large number of pods. This is not required for normal usage.

m1093782566 commented 5 years ago

Should not we report successful event during benchmark test? I am wondering if kube-scheduler is doing the same thing?

deepak-vij commented 5 years ago

/lgtm