Closed shivramsrivastava closed 5 years ago
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: shivramsrivastava
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Hi @shivramsrivastava. Thanks for your PR.
I'm waiting for a kubernetes-sigs or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
/ok-to-test
/lgtm
This PR address an issue with the failing ephemeral test case under the 'sig-scheduling'. Prior to this fix Poseidon was converting the Memory and ephemeral units to Kilobytes and this was causing a corner case to fail, since due to conversion we were losing some bytes from the memory and ephemeral calculation. Now this issue is addressed by this fix.