runtime: quote env variables for they might contain spaces

kubernetes-retired / rktlet

[EOL] The rkt implementation of the Kubernetes Container Runtime Interface

Apache License 2.0

137 stars 43 forks source link

runtime: quote env variables for they might contain spaces #116

Closed iaguis closed 7 years ago

iaguis commented 7 years ago

We also need to escape single quotes.

iaguis commented 7 years ago

I'd suggest to write some unit tests here

Will do

iaguis commented 7 years ago

I re-tested this and it seems to work without this PR for variables with spaces. I don't know why I was seeing errors before.

On the rkt side, we have some problems with variables including quotes in certain positions, but this is something we should fix there and not very important at the moment.

Closing this.