search

kubernetes-retired / rktlet

[EOL] The rkt implementation of the Kubernetes Container Runtime Interface
Apache License 2.0
137 stars 43 forks source link

vendor: update vendoring #121

Closed iaguis closed 7 years ago

iaguis commented 7 years ago

It now uses:

I had to explicitly list some dependencies to pin them to a version

I also changed some depencency revisions to match what Kubernetes has.

Finally, since I was getting compilation errors similar to the ones mentioned in kelseyhightower/kubernetes-initializer-tutorial#4, I set the version of k8s.io/apimachinery like mentioned there.

iaguis commented 7 years ago

I got pretty confused by the vendoring and the changes in kubernetes but it now compiles and seems to work.

alban commented 7 years ago

@iaguis why using rkt v1.25.0 instead of the last release?

iaguis commented 7 years ago

I chose that kinda arbitrarily because that's what k8s vendors. Although I see not that it's only us (rktlet) that use it. I'll change it to the last release and also do coreos/rkt -> rkt/rkt.

iaguis commented 7 years ago

Travis fails because tls.Config.Clone() was added in go1.8 and we're building with go1.7.

iaguis commented 7 years ago

It's green now :)

alban commented 7 years ago

It compiles fine for me.

A couple of changes in the rkt git repository were missed:

$ git grep github.com/coreos/rkt
README.md:[rkt]: https://github.com/coreos/rkt
glide.lock:- name: github.com/coreos/rkt
tests/runtime/runtime_test.go:  // Due to https://github.com/coreos/rkt/issues/3473 we need to trim spaces for each line

After the changes mentioned above, LGTM.

iaguis commented 7 years ago

Thanks! I fixed those and also removed ./vendor/github.com/coreos/rkt/

alban commented 7 years ago

lgtm