rktlet/runtime: make use of canonical image name

kubernetes-retired / rktlet

[EOL] The rkt implementation of the Kubernetes Container Runtime Interface

Apache License 2.0

137 stars 43 forks source link

rktlet/runtime: make use of canonical image name #133

Closed dongsupark closed 7 years ago

dongsupark commented 7 years ago

If rkt add app runs with an image name without a prefix docker://, add a prefix docker://. If the image name doesn't contain :, try to change it to a canonical name like "busybox:latest".

This is especially needed for testing with cri tools.

Partly covers https://github.com/kubernetes-incubator/rktlet/issues/131

dongsupark commented 7 years ago

Fixed a bug, and added a unit test for GetCanonicalImageName().

dongsupark commented 7 years ago

Fixed another bug handling hash names in the input image name. Tested, and it works. :-)

dongsupark commented 7 years ago

Exposed HashRegexp, which is needed by https://github.com/kubernetes-incubator/rktlet/pull/137.

iaguis commented 7 years ago

Two questions:

Can we use this in imagestore.PullImage()?
How would this work for people not using docker images? Is it just a matter of setting dockerPrefix to the empty string?

dongsupark commented 7 years ago

@iaguis I changed PullImage() as well, to let it make use of GetCanonicalImageName(). As for non-docker images, I'm not sure about how to deal with it. Any suggestions?

nhlfr commented 7 years ago

Is anything blocking us from merging this? ;)

iaguis commented 7 years ago

Some users of rktlet apply a patch to the kubelet (and rktlet) to be able to use ACI images instead of docker ones so I was wondering if this PR makes that kind of patch more difficult. That's the only open question from my side.