rktlet/runtime: sanitize ACName before for running rkt app

kubernetes-retired / rktlet

[EOL] The rkt implementation of the Kubernetes Container Runtime Interface

Apache License 2.0

137 stars 43 forks source link

rktlet/runtime: sanitize ACName before for running rkt app #135

Closed dongsupark closed 7 years ago

dongsupark commented 7 years ago

As appc spec does not allow lowercase characters in ACName, we should sanitize ACName before running rkt app, for subcommands add, exec, rm, start, status, and stop. Otherwise each command will fail when app name contains an uppercase character like:

error adding app to pod: ACName must contain only lower case
alphanumeric characters plus "-"

Fixes https://github.com/kubernetes-incubator/rktlet/issues/134

dongsupark commented 7 years ago

@alban Done. I updated the copyright headers also in other files, and added a document docs/limitations.md.