search

kubernetes-retired / rktlet

[EOL] The rkt implementation of the Kubernetes Container Runtime Interface
Apache License 2.0
137 stars 43 forks source link

listImage tests fail due to a single repoTag in each image #140

Closed dongsupark closed 5 years ago

dongsupark commented 7 years ago

Several cri-tools tests about listImage fail because each result image includes a single repoTag. Apparently critests require for multiple repoTags in each image.

• Failure [6.314 seconds]
[k8s.io] Image Manager
/home/dpark/go/src/github.com/kubernetes-incubator/cri-tools/pkg/framework/framework.go:72
  listImage should get exactly 2 repoTags in the result image [Conformance] [It]
  /home/dpark/go/src/github.com/kubernetes-incubator/cri-tools/pkg/validate/image.go:106

  Should have two repoTags in single image in list
  Expected 
      <int>: 0
  to equal
      <int>: 2

  /home/dpark/go/src/github.com/kubernetes-incubator/cri-tools/pkg/validate/image.go:133

It's clear that rktlet returns a list of images, each of which contains a single repoTag.

STEP: framework.ListImage returned image: &Image{Id:sha512-b5235267dc97295f5782228509950655576903245e863a4ca4f339d322d5e544,RepoTags:[quay.io/coreos/rktlet-journal2cri:0.0.1],RepoDigests:[sha512-b5235267dc97295f5782228509950655576903245e863a4ca4f339d322d5e544],Size_:256870369,Uid:nil,Username:0,}
STEP: framework.ListImage returned image: &Image{Id:sha512-d159247ff1e2df28593c4610033fe8f57b2b5fd6d2c92449942f1031ab079488,RepoTags:[coreos.com/rkt/stage1-coreos:1.28.1+git020d59b9],RepoDigests:[sha512-d159247ff1e2df28593c4610033fe8f57b2b5fd6d2c92449942f1031ab079488],Size_:226893408,Uid:&Int64Value{Value:0,},Username:,}
STEP: framework.ListImage returned image: &Image{Id:sha512-44fd792bc8baa533f3c033a2b3bc2f1b2a272615245a3f4795a142c1bff6c979,RepoTags:[busybox:1.26],RepoDigests:[sha512-44fd792bc8baa533f3c033a2b3bc2f1b2a272615245a3f4795a142c1bff6c979],Size_:2424818,Uid:nil,Username:0,}
STEP: framework.ListImage returned image: &Image{Id:sha512-36f849e5ff591d25fc1bf6a926960c5f77c0e4d55c020a043ccf333f1635cb3a,RepoTags:[nginx:latest],RepoDigests:[sha512-36f849e5ff591d25fc1bf6a926960c5f77c0e4d55c020a043ccf333f1635cb3a],Size_:217083282,Uid:nil,Username:0,}
STEP: framework.ListImage returned image: &Image{Id:sha512-094b8f05ddd537074909622b76696a2ff168b269015cfb3e975532fd8c1c76d9,RepoTags:[busybox:1-uclibc],RepoDigests:[sha512-094b8f05ddd537074909622b76696a2ff168b269015cfb3e975532fd8c1c76d9],Size_:1341952,Uid:nil,Username:0,}
STEP: framework.ListImage returned image: &Image{Id:sha512-3636d65a47ca7f775af4c051bd4298fd1500468eb1a596e001dc9c2f5fb26e2e,RepoTags:[busybox:1],RepoDigests:[sha512-3636d65a47ca7f775af4c051bd4298fd1500468eb1a596e001dc9c2f5fb26e2e],Size_:1341952,Uid:nil,Username:0,}
STEP: Remove image : busybox:1-uclibc
STEP: After ImageStatus, image: &Image{Id:sha512-094b8f05ddd537074909622b76696a2ff168b269015cfb3e975532fd8c1c76d9,RepoTags:[busybox:1-uclibc],RepoDigests:[sha512-094b8f05ddd537074909622b76696a2ff168b269015cfb3e975532fd8c1c76d9],Size_:1341952,Uid:nil,Username:0,}

I'm not sure why the critests want to ensure the two repotags in a single image. I think rktlet does the right job. I'm going to look into cri-o as well to figure out what's going on.

fejta-bot commented 5 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

fejta-bot commented 5 years ago

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle rotten

fejta-bot commented 5 years ago

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /close

k8s-ci-robot commented 5 years ago

@fejta-bot: Closing this issue.

In response to [this](https://github.com/kubernetes-incubator/rktlet/issues/140#issuecomment-504283233): >Rotten issues close after 30d of inactivity. >Reopen the issue with `/reopen`. >Mark the issue as fresh with `/remove-lifecycle rotten`. > >Send feedback to sig-testing, kubernetes/test-infra and/or [fejta](https://github.com/fejta). >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.