search

kubernetes-retired / rktlet

[EOL] The rkt implementation of the Kubernetes Container Runtime Interface
Apache License 2.0
137 stars 43 forks source link

Basic CRI implementations #16

Closed yifan-gu closed 8 years ago

yifan-gu commented 8 years ago

Pulled from #6 , made some small changes, and added code to run rkt commands under systemd-run.

Depends #15 to get in first.

cc @s-urbaniak @lucab

pskrzyns commented 8 years ago

@yifan-gu I think we can merge it so we can move forward. We can just create issues for the things I mentioned

yifan-gu commented 8 years ago

@yifan-gu I think we can merge it so we can move forward. We can just create issues for the things I mentioned

OK, let me fix things you mentioned in the comments shortly. I actually pushed more commits on implementing other interfaces. But we can split them into follow up PRs.

pskrzyns commented 8 years ago

hmm, gihub needs to add removing approval option ;) I took a look on new commits and they are looking OK.

yifan-gu commented 8 years ago

OK, merging this.