CRI: Support exposing ports.

kubernetes-retired / rktlet

[EOL] The rkt implementation of the Kubernetes Container Runtime Interface

Apache License 2.0

137 stars 43 forks source link

Closed yifan-gu closed 8 years ago

yifan-gu commented 8 years ago

cc @euank

Would modify the upstream to remove unnecessary Name field, and the skip when host port == 0.

euank commented 8 years ago

Since the upstream changes are in, this can be rebased and a couple TODOs removed. Looks good other than that

yifan-gu commented 8 years ago

Updated. @euank

yifan-gu commented 8 years ago

Updated the PR. PTAL @euank

euank commented 8 years ago

LGTM! You have to actually do some clicking for the cla stuff (here), but I know your company signed it so we'll go with human verified :)