search

kubernetes-retired / rktlet

[EOL] The rkt implementation of the Kubernetes Container Runtime Interface
Apache License 2.0
137 stars 43 forks source link

OCI: annotation for pulling/running OCI image #41

Closed philips closed 5 years ago

philips commented 8 years ago

Similar to the annotation to change the stage1 (rkt.alpha.kubernetes.io/stage1-name-override) lets add an experimental annotation to pull an OCI image instead of a Docker image (pod.v1.kubernetes.io/image-type=oci).

This was out of a brief conversation with @vishh about how to support OCI before we get an agreed upon proposal for https://github.com/kubernetes/features/issues/63.

euank commented 8 years ago

Depends on https://github.com/coreos/rkt/issues/3134

philips commented 8 years ago

@euank this already works, that flag is to just make it more explicitly an experiment.

lucab commented 8 years ago

Gating it behind a flag is the part that is still missing. I'm going through some docker2aci backlog, I should get to that too this week.

philips commented 8 years ago

Right, but it is working today: https://groups.google.com/a/opencontainers.org/forum/#!topic/dev/Am7byGvLCUQ

On Tue, Oct 18, 2016 at 11:02 AM Luca Bruno notifications@github.com wrote:

Gating it behind a flag is the part that is still missing. I'm going through some docker2aci backlog, I should get to that too this week.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/kubernetes-incubator/rktlet/issues/41#issuecomment-254589347, or mute the thread https://github.com/notifications/unsubscribe-auth/AACDCLtpS14qg6SNMS2_DHRun3vOIhdxks5q1Qm_gaJpZM4KZLrL .

fejta-bot commented 5 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

fejta-bot commented 5 years ago

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle rotten

fejta-bot commented 5 years ago

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /close

k8s-ci-robot commented 5 years ago

@fejta-bot: Closing this issue.

In response to [this](https://github.com/kubernetes-incubator/rktlet/issues/41#issuecomment-504273702): >Rotten issues close after 30d of inactivity. >Reopen the issue with `/reopen`. >Mark the issue as fresh with `/remove-lifecycle rotten`. > >Send feedback to sig-testing, kubernetes/test-infra and/or [fejta](https://github.com/fejta). >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.