kubernetes-retired / rktlet

[EOL] The rkt implementation of the Kubernetes Container Runtime Interface
Apache License 2.0
137 stars 43 forks source link

network plugins #50

Closed euank closed 5 years ago

euank commented 8 years ago

It was decided that the runtime should manage network plugins, so we should use the kubenet/cni packages that exist in Kubernetes in order to keep compatibility.

For compatibility with other Kubernetes runtimes, we should be able to support kubenet/cni, or something very like it.

For the current rkt integration, we depended entirely on the Kubenretes-CNI, but the reasons are largely outdated (pod ip not available prior to running apps; rkt-CRI fixes that).

The main consideration now is configuration-directory compatibility and any other differences kubenet has from pure CNI.

We might be able to get away with rkt-cni now. cc @squeed

squeed commented 8 years ago

Cool. We can definitely get away with most of the work done in CNI, but there are a few things not currently supported there:

-traffic shaping -firewalling -port forwarding (though rkt handles this)

Also: there are a few connection tunables, such as MTU, that need to be injected in to the CNI config on disk :-/

fejta-bot commented 5 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

fejta-bot commented 5 years ago

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle rotten

fejta-bot commented 5 years ago

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /close

k8s-ci-robot commented 5 years ago

@fejta-bot: Closing this issue.

In response to [this](https://github.com/kubernetes-incubator/rktlet/issues/50#issuecomment-504273698): >Rotten issues close after 30d of inactivity. >Reopen the issue with `/reopen`. >Mark the issue as fresh with `/remove-lifecycle rotten`. > >Send feedback to sig-testing, kubernetes/test-infra and/or [fejta](https://github.com/fejta). >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.