repo-cleanup: We should run the github munger

kubernetes-retired / rktlet

[EOL] The rkt implementation of the Kubernetes Container Runtime Interface

Apache License 2.0

137 stars 43 forks source link

repo-cleanup: We should run the github munger #51

Closed euank closed 5 years ago

euank commented 8 years ago

Once we're running it, we should also add a labels.yaml similar to the one in the k8s repo proper and the bot'll create a bunch of nice labels for us!

There are instructions over here.

@spxtr: Can we point the existing munger or a k8s/goog managed munger at incubator repos?

spxtr commented 8 years ago

We're working on making that easier, but it's a little tricky right now. For the munger, I think you need to turn up a new one for each repo, and I'm not sure how easy that is. @apelisse probably knows better than I do.

apelisse commented 8 years ago

Yes, we could create a new instance of the mungebot for this repository. Unfortunately, we start to realize that it's not going to scale nicely (we'll end-up with one instance per repo, and that's a little bit too many).

A couple of questions:

What features exactly are you interested in?
What is the timeline?

We are trying to move some of the code to a new bot that will make things much simpler. The more feature you need the more time it would take, so we need to decide if we should create a new instance of the existing bot, or wait for the new bot to be ready.

euank commented 7 years ago

Sorry for falling off the face of this issue for a bit!

The important ones to me would be the check-labels munger and the submit queue / LGTM merge logic. I know the second of those is much more complicated.

Timeline isn't urgent (obviously if I can forget about this for a month :roll_eyes:).

I'm considering running it manually for the labels.yaml bit if that sounds reasonable.

Are there any others you'd expect I'd want or has anything about how easy this might be changed? @apelisse

fejta-bot commented 5 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

fejta-bot commented 5 years ago

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle rotten

fejta-bot commented 5 years ago

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /close

k8s-ci-robot commented 5 years ago

@fejta-bot: Closing this issue.

In response to [this](https://github.com/kubernetes-incubator/rktlet/issues/51#issuecomment-504283210): >Rotten issues close after 30d of inactivity. >Reopen the issue with `/reopen`. >Mark the issue as fresh with `/remove-lifecycle rotten`. > >Send feedback to sig-testing, kubernetes/test-infra and/or [fejta](https://github.com/fejta). >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.