search

kubernetes-retired / rktlet

[EOL] The rkt implementation of the Kubernetes Container Runtime Interface
Apache License 2.0
137 stars 43 forks source link

Exec implementation #54

Closed euank closed 7 years ago

euank commented 8 years ago

This also has some other minor refactoring related to that. Commits are well split up for reviewing ease.

Testing is the big missing piece of this (like many other things). Manually tested after merging https://github.com/kubernetes/kubernetes/pull/36020 and https://github.com/kubernetes/kubernetes/issues/34987 into my Kubernetes.

euank commented 7 years ago

Rebased on top of #48 and #57 and should only be merged after those two are.

Works with upstream k8s with https://github.com/kubernetes/kubernetes/pull/36253 merged (which is currently LGTM).

cc @squeed, afaik this is good to go (other than the dependencies). You're also welcome to copy/rebase/split out if my stack of specially ordered rebases works against you.

euank commented 7 years ago

rebased now that all dependencies are merged

yifan-gu commented 7 years ago

Overall seems good, thanks @euank !

euank commented 7 years ago

Replied/addressed your comments, LGTY?

yifan-gu commented 7 years ago

LGTM