Standardize docker name, update user logic

kubernetes-retired / rktlet

[EOL] The rkt implementation of the Kubernetes Container Runtime Interface

Apache License 2.0

137 stars 43 forks source link

Standardize docker name, update user logic #60

Closed euank closed 7 years ago

euank commented 7 years ago

This gets us back to a working state again with the User and image tag defaulting changes that happened upstream.

This also takes advantage of using the image annotation of its original name to behave more correctly when listing images.

cc @yifan-gu @squeed

Fixes #49

lucab commented 7 years ago

LGTM, except a small comment regarding validation (that perhaps we want to tackle later).

squeed commented 7 years ago

A few small questions, but they are mostly more general. Seems reasonable to me.

euank commented 7 years ago

Addressed all comments, and I fixed a few more issues with the code that I uncovered (specifically returning empty, nil for "image does not exist" case and defaulting the originalname with a tag too).

I think this is good to go.