Integration tests: tracking issue

kubernetes-retired / rktlet

[EOL] The rkt implementation of the Kubernetes Container Runtime Interface

Apache License 2.0

137 stars 43 forks source link

Integration tests: tracking issue #64

Closed euank closed 5 years ago

euank commented 7 years ago

Right now, we have travis-ci and a smattering of unit tests.

Since rktlet is a fairly thin wrapper around rkt, we'll get lots of value out of having some integration tests too.

Integration with Kubernetes is also important, but we should be able to lean on the e2e and other tests already written there, so we can just do the CI work for those, not have to write the tests too.

[x] Unit tests are run for each PR
[ ] Integration tests for rktlet -> rkt
- [x] Integration test framework exists for doing common setup/teardown to make writing tests easy
- [ ] Tests with basic coverage exist
- [x] A CI system capable of running containers is chosen/configured (i.e. not Travis)
- [ ] Tests run against master
- [x] Tests run on each PR
[ ] Integration tests for Kubernetes -> rktlet
- [ ] Tests have been run successfully locally (#52)
- [ ] Tests run against each revision of master

euank commented 7 years ago

cc @lucab

fejta-bot commented 5 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

fejta-bot commented 5 years ago

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle rotten

fejta-bot commented 5 years ago

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /close

k8s-ci-robot commented 5 years ago

@fejta-bot: Closing this issue.

In response to [this](https://github.com/kubernetes-incubator/rktlet/issues/64#issuecomment-504283220): >Rotten issues close after 30d of inactivity. >Reopen the issue with `/reopen`. >Mark the issue as fresh with `/remove-lifecycle rotten`. > >Send feedback to sig-testing, kubernetes/test-infra and/or [fejta](https://github.com/fejta). >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.