kubernetes-retired / rktlet

[EOL] The rkt implementation of the Kubernetes Container Runtime Interface
Apache License 2.0
137 stars 43 forks source link

runtime: fix list pod sandbox reference-overriding #70

Closed euank closed 7 years ago

euank commented 7 years ago

The included test failed prior to the small pod_sandbox change.

This is due to the usual gotcha of loop variables in go sharing the same address, and the toPodSandboxStatus function returns references to parts of that struct, which end up becoming wrong after another loop.

I'm pretty sure this explains a lot of troubles I've had with kubelet not being able to find some pod UIDs.