kubernetes-retired / rktlet

[EOL] The rkt implementation of the Kubernetes Container Runtime Interface
Apache License 2.0
137 stars 43 forks source link

runtime: support cpushares correctly #78

Closed euank closed 7 years ago

euank commented 7 years ago

I've got an integ test for this too, but it's blocked on privileged so it can read /sys/fs/cgroup, and as such I haven't actually run the test.

I'd prefer to followup with it once privileged is there.

s-urbaniak commented 7 years ago

This should land in rk1.22.0 when the R/W backport lands in Container Linux and thus in the coreos stage1 image.

jonboulle commented 7 years ago

@squeed

squeed commented 7 years ago

LGTM!

euank commented 7 years ago

Did the trivial rebase for it, merging