search

kubernetes-retired / rktlet

[EOL] The rkt implementation of the Kubernetes Container Runtime Interface
Apache License 2.0
137 stars 43 forks source link

Should rktlet use a separate data directory? #93

Closed squeed closed 5 years ago

squeed commented 7 years ago

Right now, the rktlet uses a separate data directory for rkt - /var/lib/rktlet/data - instead of the default. This means that commands like rkt list and rkt gc don't work without manually specifying the datadir.

On the one hand, this is good for isolation. On the other hand, this might be very confusing for users.

euank commented 7 years ago

Options for improving UX include a "kube-rkt" wrapper that invokes rkt with the correct data directory or the like.. though that's not all that great.

The problems to think about with not having a separate data directory:

1) if the rkt version used for k8s differs from the one used by the host (e.g. as packaged for mounters in gci or for etcd/os/etc for container linux) then not having a separate data directory has a chance at breaking either side when changes to on-disk format are made. 2) the rktlet is designed with the expectation that it recognizes all images right now. The previous kubelet/rkt code would check if a special annotation existed to determine if it should manage a given pod, rktlet just manages everything. This code would need to be changed.

squeed commented 7 years ago

Oh, good point about there being parallel rkt version on the host. How likely do we think that is to happen?

As for point 2, do you mean images or pods? (I suspect you mean pods). Indeed, that makes sense that we'd have to flag pods as kubelet-requested-pods, lest the kubelet see itself running (in rkt fly) and decide to clean itself up :-)

fejta-bot commented 5 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

fejta-bot commented 5 years ago

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle rotten

fejta-bot commented 5 years ago

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /close

k8s-ci-robot commented 5 years ago

@fejta-bot: Closing this issue.

In response to [this](https://github.com/kubernetes-incubator/rktlet/issues/93#issuecomment-504283225): >Rotten issues close after 30d of inactivity. >Reopen the issue with `/reopen`. >Mark the issue as fresh with `/remove-lifecycle rotten`. > >Send feedback to sig-testing, kubernetes/test-infra and/or [fejta](https://github.com/fejta). >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.