search

kubernetes-retired / service-catalog

Consume services in Kubernetes using the Open Service Broker API
https://svc-cat.io
Apache License 2.0
1.05k stars 384 forks source link

Broker's preferred plan ordering is lost #1247

Closed spadgett closed 6 years ago

spadgett commented 7 years ago

Brokers return plans for a service as an array. Now that plans have been split out into a separate resource with a reference back to the service class, the order is lost. Clients can no longer display the plans in the broker's preferred order.

duglin commented 7 years ago

I'm not sure the list is ordered from the broker - at least per the spec.

pmorie commented 7 years ago

Upon further consideration, I think ServiceClass should have an array of human-readable plan names, possibly with references to the ServicePlans.

spadgett commented 7 years ago

@duglin I could be misreading the spec, but I assume since it's defined as an array here it's ordered?

https://github.com/openservicebrokerapi/servicebroker/blob/master/spec.md#service-objects

duglin commented 7 years ago

yup - its an array, but it doesn't say its ordered or that the order has any meaning like "preferred" first.

MHBauer commented 6 years ago

An array because that's what javascript supported, not because the order is important.