Separate binding injection into configmap, secret, and service

kubernetes-retired / service-catalog

Consume services in Kubernetes using the Open Service Broker API

https://svc-cat.io

Apache License 2.0

1.05k stars 384 forks source link

Separate binding injection into configmap, secret, and service #165

Closed bmelville closed 2 years ago

bmelville commented 7 years ago

Binding injection needs to separate the binding credential into three groups of data:

Secret information to be stored in a Secret resource
Non-secret information to be stored in a ConfigMap resource
Endpoint information to be stored in a Service resource

Because binding credentials are an unstructured data map, there are some key questions to address to solve this properly:

How to determine whether a piece of data is secret
How to determine whether a piece of data is endpoint information

It may be fine for the short term to hard code known field names to be deemed secrets or endpoints, e.g.,

host, hostname, ip, address, and port are endpoint fields
username, uname, user, and password are secret fields

Depends on #146

bmelville commented 7 years ago

This is blocked by features in the Open Service Broker API.

General schematization of credential data: https://github.com/openservicebrokerapi/servicebroker/issues/116 Secret vs. non-secret data: https://github.com/openservicebrokerapi/servicebroker/issues/117 Endpoint information: https://github.com/openservicebrokerapi/servicebroker/issues/121

fejta-bot commented 5 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

fejta-bot commented 5 years ago

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle rotten

fejta-bot commented 5 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

fejta-bot commented 5 years ago

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle rotten

mszostok commented 5 years ago

/remove-lifecycle rotten /lifecycle frozen

mrbobbytables commented 2 years ago

This project is being archived, closing open issues and PRs. Please see this PR for more information: https://github.com/kubernetes/community/pull/6632

/close

k8s-ci-robot commented 2 years ago

@mrbobbytables: Closing this issue.

In response to [this](https://github.com/kubernetes-sigs/service-catalog/issues/165#issuecomment-1119674707): >This project is being archived, closing open issues and PRs. >Please see this PR for more information: https://github.com/kubernetes/community/pull/6632 > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.