search

kubernetes-retired / service-catalog

Consume services in Kubernetes using the Open Service Broker API
https://svc-cat.io
Apache License 2.0
1.05k stars 385 forks source link

X-Broker-API-Originating-Identity Does not have extras #1701

Closed shawn-hurley closed 6 years ago

shawn-hurley commented 6 years ago

Service Catalog does not send over extra fields in extra instead it is a top level of the created object.

Actual results:

X-Broker-API-Originating-Identity Header: kubernetes eyJncm91cHMiOlsic3lzdGVtOmF1dGhlbnRpY2F0ZWQ6b2F1dGgiLCJzeXN0ZW06YXV0aGVudGljYXRlZCJdLCJzY29wZXMuYXV0aG9yaXphdGlvbi5vcGVuc2hpZnQuaW8iOlsidXNlcjpmdWxsIiwidXNlcjpsaXN0LXByb2plY3RzIiwidXNlcjppbmZvIiwicm9sZTphZG1pbjpuZXctcHJvamVjdDohIl0sInVpZCI6IiIsInVzZXJuYW1lIjoiZGV2ZWxvcGVyIn0=

{"groups":["system:authenticated:oauth","system:authenticated"],"scopes.authorization.openshift.io":["user:full","user:list-projects","user:info","role:admin:new-project:!"],"uid":"","username":"developer"}

Expected results:

eyJncm91cHMiOlsic3lzdGVtOmF1dGhlbnRpY2F0ZWQ6b2F1dGgiLCJzeXN0ZW06YXV0aGVudGljYXRlZCJdLGV4dHJhOnsic2NvcGVzLmF1dGhvcml6YXRpb24ub3BlbnNoaWZ0LmlvIjpbInVzZXI6aW5mbyJdfSwidWlkIjoiIiwidXNlcm5hbWUiOiJkZXZlbG9wZXIifQo=

{"groups":["system:authenticated:oauth","system:authenticated"],extra:{"scopes.authorization.openshift.io":["user:info"]},"uid":"","username":"developer"}
MHBauer commented 6 years ago

Does look like a bug.

MHBauer commented 6 years ago

https://github.com/openservicebrokerapi/servicebroker/blob/v2.13/profile.md#kubernetes

shawn-hurley commented 6 years ago

Thanks for finding the link, I should have included in my initial bug report