Closed shiresky closed 3 years ago
Hi @shiresky. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: shiresky
To complete the pull request process, please assign piotrmiskiewicz after the PR has been reviewed.
You can assign the PR to them by writing /assign @piotrmiskiewicz
in a comment when ready.
The full list of commands accepted by this bot can be found here.
/assign @piotrmiskiewicz CI pipeline fail and I don't know why. @piotrmiskiewicz can you help me?
Unknown CLA label state. Rechecking for CLA labels.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /check-cla
ci isn't running because you haven't signed the CLA for contributing to Kubernetes. Additionally, I don't think we let people insert random copyright into our projects, you have to contribute under the guidelines for contributing to Kubernetes
This PR is a
What this PR does / why we need it: Webhooks uses sigs.k8s.io/controller-runtime/pkg/manager module that by default binds 8080 port to expose metrics. I need to use host network for webhooks and this port is already occupied. that's why I need to make it configurable.
Please leave this checklist in the PR comment so that maintainers can ensure a good PR.
Merge Checklist: