Closed jiayihu closed 3 years ago
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.
It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Welcome @jiayihu!
It looks like this is your first PR to kubernetes-sigs/service-catalog 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes-sigs/service-catalog has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
Hi @jiayihu. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
This is uneeded as the helm chart creates the namespace.
That is not true, at least in Helm v3. It gives error if the namespace is not created before or if you don't pass the flag --create-namespace
: https://github.com/helm/helm/pull/7648
Official docs also state it: https://helm.sh/docs/faq/#automatically-creating-namespaces
Ah, i wasn't aware that was SOP in helm3
Could you move this down a tab, so it's included in 'helm 3 ' section?
Sure, it should be fine now although I'm not sure how the tabs thing works sorry. Also, to be quick, I edited using GH website so I hope you don't mind squashing the two commits.
squashing the commits is fine, the tab things are for the docs website
in other news, it looks like our CI is blowing up so it might be a bit before this gets merged
/ok-to-test
/retest
/ok-to-test
/retest
/retest
/lgtm
Cyberpunk 2077 will still have robots failing because of a change in a Markdown file
LOL
/lgtm /approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jberkhahn, jiayihu
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/retest
This PR is a
What this PR does / why we need it:
Which issue(s) this PR fixes
Fixes #
Please leave this checklist in the PR comment so that maintainers can ensure a good PR.
Merge Checklist: