kubernetes-retired / service-catalog

Consume services in Kubernetes using the Open Service Broker API
https://svc-cat.io
Apache License 2.0
1.05k stars 387 forks source link

Metrics not recognizing ServiceBroker and ClusterServiceBroker #2872

Closed kjaksik closed 3 years ago

kjaksik commented 3 years ago

Bug Report

What happened:

Metrics from ServiceBrokers and ClusterServiceBrokers can be overwritten by any other Broker with the same name, even if another namespace.

What you expected to happen:

Different brokers to have separate metrics.

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:

Environment:

kjaksik commented 3 years ago

My idea to fix that would be to add a suffix with the namespace name to ServiceBrokers metrics here and here