kubernetes-retired / service-catalog

Consume services in Kubernetes using the Open Service Broker API
https://svc-cat.io
Apache License 2.0
1.05k stars 385 forks source link

Add namespace to service broker metrics #2873

Closed kjaksik closed 3 years ago

kjaksik commented 3 years ago

This PR is a

What this PR does / why we need it:

This PR Fixes an issue in SC metrics Which issue(s) this PR fixes

Fixes #2872

Please leave this checklist in the PR comment so that maintainers can ensure a good PR.

Merge Checklist:

k8s-ci-robot commented 3 years ago

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
k8s-ci-robot commented 3 years ago

Welcome @kjaksik!

It looks like this is your first PR to kubernetes-sigs/service-catalog 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/service-catalog has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot commented 3 years ago

Hi @kjaksik. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
kjaksik commented 3 years ago

/check-cla

jberkhahn commented 3 years ago

/ok-to-test

jberkhahn commented 3 years ago

/retest

kjaksik commented 3 years ago

Hi @jberkhahn, Thanks for the ok to test 😄 I will look into the CI failures tommorow

jberkhahn commented 3 years ago

thanks. I think the CR failures are due to a bump in test-infra that changes the base images, rather than your thing

kjaksik commented 3 years ago

/retest

kjaksik commented 3 years ago

/retest

kjaksik commented 3 years ago

/retest

kjaksik commented 3 years ago

@jberkhahn Ok, I managed to fix most of the jobs, they required changing the helm default repo. In 2.16.7 it was hardcoded for the one that's not being resolved now. The TravisCI job fails because there's a difference in the boiler plate of the generated components. It expects the year to be 2021 and it's still left in 2020 😄 , I can regenerate those files but I'm not sure if they should be on this PR

jberkhahn commented 3 years ago

I can regenerate those files but I'm not sure if they should be on this PR

Yeah, if you could submit that as a separate PR that would be great.

jhvhs commented 3 years ago

@kjaksik Resolving the CI/helm issues unfortunately resulted in conflicts. Could you please resolve them?

kjaksik commented 3 years ago

@jhvhs sure, fixed the conflicts

kjaksik commented 3 years ago

/retest

piotrmiskiewicz commented 3 years ago

/lgtm

jhvhs commented 3 years ago

/approve

k8s-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhvhs, kjaksik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/service-catalog/blob/master/OWNERS)~~ [jhvhs] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment