search

kubernetes-retired / service-catalog

Consume services in Kubernetes using the Open Service Broker API
https://svc-cat.io
Apache License 2.0
1.05k stars 387 forks source link

switch CRDs to v1 #2879

Closed shiresky closed 2 years ago

shiresky commented 3 years ago

This PR is a

What this PR does / why we need it:

service-catalog chart contains CustomResourceDefinition manifests in API group apiextensions.k8s.io/v1beta1 that is deprecated in v1.16 in favor of apiextensions.k8s.io/v1.

Merge Checklist:

k8s-ci-robot commented 3 years ago

Hi @shiresky. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
k8s-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: shiresky To complete the pull request process, please assign piotrmiskiewicz after the PR has been reviewed. You can assign the PR to them by writing /assign @piotrmiskiewicz in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-sigs/service-catalog/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
jberkhahn commented 3 years ago

/ok-to-test

k8s-ci-robot commented 3 years ago

@shiresky: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-service-catalog-test-e2e-k8s-1-16-9 c51bbf135632bbc78c2672e8fd342da6024f0c9a link /test pull-service-catalog-test-e2e-k8s-1-16-9
pull-service-catalog-test-e2e-k8s-1-18-2 c51bbf135632bbc78c2672e8fd342da6024f0c9a link /test pull-service-catalog-test-e2e-k8s-1-18-2
pull-service-catalog-test-e2e-k8s-1-17-5 c51bbf135632bbc78c2672e8fd342da6024f0c9a link /test pull-service-catalog-test-e2e-k8s-1-17-5
pull-service-catalog-test-migration c51bbf135632bbc78c2672e8fd342da6024f0c9a link /test pull-service-catalog-test-migration
pull-service-catalog-test-integration c51bbf135632bbc78c2672e8fd342da6024f0c9a link /test pull-service-catalog-test-integration

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
shiresky commented 3 years ago

I'm affraid that tests would never pass because of protected groups must have approval annotation "api-approved.kubernetes.io", see https://github.com/kubernetes/enhancements/pull/1111 I have also encountered this communicate on K8s 1.19 but not on K8s 1.18.

shiresky commented 3 years ago

Can anybody comment if the issue is possible to resolve or there is Kubernetes code change necessary? @jberkhahn @jhvhs

jhvhs commented 3 years ago

@shiresky I'm looking into it. Will let you know once I figure it out.

jhvhs commented 3 years ago

/label api-review

shiresky commented 3 years ago

Hi @jhvhs ! Were you able to take a look? Any idea/conclusions?

jhvhs commented 3 years ago

Hi @jhvhs ! Were you able to take a look? Any idea/conclusions?

I'm preparing this issue for the review process. I'm hoping that it won't take too long.

liggitt commented 3 years ago

To unblock this PR, you can add an "api-approved.kubernetes.io":"unapproved, review tracked in https://github.com/kubernetes-sigs/service-catalog/issues/####" annotation as described in https://github.com/kubernetes/enhancements/blob/master/keps/sig-api-machinery/2337-k8s.io-group-protection/README.md#what-to-do-if-you-accidentally-put-an-unapproved-api-in-a-protected-group

Regarding API review, it looks like there were some interactions with API reviewers in the early days regarding naming, etc, but I don't see an actual review of the schemas themselves:

cc @thockin @smarterclayton as API reviewers that interacted with these types in the past cc @pmorie as early API driver, in case you have pointers to docs or PRs where review was done

Spelunking through API history:

liggitt commented 3 years ago

/retitle switch CRDs to v1

smarterclayton commented 3 years ago

There was a lot of early review, but this has been dormant so long and the sig focus was lost and changed (I guess) that I'd have to revisit. The APIs were specifically modelled to make interop with the service broker project - if that focus has changed it's not clear to me that the APIs still accomplish their goal so I think I'd need to see context about "where is service-catalog going" in order to review (which I would be happy to get involved in since the broader service-catalog mission has a lot of value as a generic api).

EDIT: Roughly "I don't think previous review is sufficient in terms of direction to say this meets the newer criteria for V1 APIs and review. I would be happy to dig in and help get understanding of what needs to be done to meet that bar once I have more context for the changes".

jhvhs commented 3 years ago

I think I'd need to see context about "where is service-catalog going" in order to review (which I would be happy to get involved in since the broader service-catalog mission has a lot of value as a generic api).

@smarterclayton There were no changes to the service-catalog project direction, it is still an OSBAPI implementation. However, the SIG itself is planning to extend the scope within the same area in order to be able to go beyond OSBAPI - https://github.com/kubernetes/community/pull/5746

shiresky commented 3 years ago

Hi @jhvhs @smarterclayton

what is the final decision on this PR?

k8s-triage-robot commented 2 years ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot commented 2 years ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

jintusebastian commented 2 years ago

Hi @jhvhs @smarterclayton @shiresky

Any updates on this PR? and support for K8s v1.22?

avirampi commented 2 years ago

is there any thing new about the support for k8s v1.22

k8s-triage-robot commented 2 years ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-ci-robot commented 2 years ago

@k8s-triage-robot: Closed this PR.

In response to [this](https://github.com/kubernetes-sigs/service-catalog/pull/2879#issuecomment-1006613979): >The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. > >This bot triages issues and PRs according to the following rules: >- After 90d of inactivity, `lifecycle/stale` is applied >- After 30d of inactivity since `lifecycle/stale` was applied, `lifecycle/rotten` is applied >- After 30d of inactivity since `lifecycle/rotten` was applied, the issue is closed > >You can: >- Reopen this issue or PR with `/reopen` >- Mark this issue or PR as fresh with `/remove-lifecycle rotten` >- Offer to help out with [Issue Triage][1] > >Please send feedback to sig-contributor-experience at [kubernetes/community](https://github.com/kubernetes/community). > >/close > >[1]: https://www.kubernetes.dev/docs/guide/issue-triage/ Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.