Handle panic with nil map on reconcile

kubernetes-retired / service-catalog

Consume services in Kubernetes using the Open Service Broker API

https://svc-cat.io

Apache License 2.0

1.05k stars 385 forks source link

Handle panic with nil map on reconcile #2884

Closed polskikiel closed 3 years ago

polskikiel commented 3 years ago

This PR is a

[ ] Feature Implementation
[x] Bug Fix
[ ] Documentation

What this PR does / why we need it:

Which issue(s) this PR fixes

Fixes #2825

Please leave this checklist in the PR comment so that maintainers can ensure a good PR.

Merge Checklist:

[ ] New feature
- [ ] Tests
- [ ] Documentation
[ ] SVCat CLI flag
[ ] Server Flag for config
- [ ] Chart changes
- [ ] removing a flag by marking deprecated and hiding to avoid breaking the chart release and existing clients who provide a flag that will get an error when they try to update

k8s-ci-robot commented 3 years ago

Hi @polskikiel. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

piotrmiskiewicz commented 3 years ago

/ok-to-test

piotrmiskiewicz commented 3 years ago

/retest

polskikiel commented 3 years ago

/test pull-service-catalog-test-integration

piotrmiskiewicz commented 3 years ago

/lgtm

piotrmiskiewicz commented 3 years ago

/approve

k8s-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: piotrmiskiewicz, polskikiel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/service-catalog/blob/master/OWNERS)~~ [piotrmiskiewicz] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment