kubernetes-retired / service-catalog

Consume services in Kubernetes using the Open Service Broker API
https://svc-cat.io
Apache License 2.0
1.05k stars 387 forks source link

Stop relying setting RemoveSelfLink=false feature-gate - we're locking it to true with GA graduation in 1.24 #2909

Closed wojtek-t closed 2 years ago

wojtek-t commented 2 years ago

Upstream Kubernetes is going to get rid of ability to set SelfLink in release 1.24 (basically graduate graduate RemoveSelfLink feature gate to stable - see the KEP https://github.com/kubernetes/enhancements/tree/master/keps/sig-api-machinery/1164-remove-selflink, for a bit more details).

It seems that volcano is still vendoring Kubernetes version that is setting it to false: https://github.com/kubernetes-sigs/service-catalog/blob/master/vendor/k8s.io/apiserver/pkg/features/kube_features.go#L145

This is one more heads'up to stop relying on it (if you do in any place).

k8s-triage-robot commented 2 years ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

mrbobbytables commented 2 years ago

This project is being archived, closing open issues and PRs. Please see this PR for more information: https://github.com/kubernetes/community/pull/6632