search

kubernetes-retired / spartakus

[EOL] Anonymous Usage Collector
Apache License 2.0
74 stars 30 forks source link

V1 of Spartakus #1

Closed thockin closed 7 years ago

thockin commented 7 years ago

Starting with some sample code I hacked and slashed. This seems to work. Reviewing will be painful, I suggest just perusing the codebase, ignoring godeps.

thockin commented 7 years ago

@sarahnovotny @aronchick

thockin commented 7 years ago

regarding import paths. We have, thus far, reserved k8s.io/foo as an alias to github.com/kubernetes/foo. I could do something special for incubator, but this is currently a manual process, so I'd rather not.

On Tue, Sep 20, 2016 at 9:31 PM, Brandon Philips notifications@github.com wrote:

@philips commented on this pull request.

In Makefile https://github.com/kubernetes-incubator/spartakus/pull/1#pullrequestreview-882642 :

@@ -15,7 +15,7 @@ .PHONY: all push container clean

BIN = spartakus -PKG = k8s.io/spartakus

aside: any chance we could get k8s.io/incubator or something?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/kubernetes-incubator/spartakus/pull/1#pullrequestreview-882642, or mute the thread https://github.com/notifications/unsubscribe-auth/AFVgVE7fa7VPADChrsbPwqwUXhuAOkAjks5qsLMXgaJpZM4KBOcr .