Closed squat closed 7 years ago
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.
Once you've signed, please reply here (e.g. "I signed it!") and we'll verify. Thanks.
fixes: #12
LGTM
sanity: I know it's not total garbage :) But since the whole report is voluntary, it could all be garbage, so probably moot.
On Wed, Nov 30, 2016 at 9:03 PM, Brandon Philips notifications@github.com wrote:
@philips commented on this pull request.
In pkg/collector/api.go https://github.com/kubernetes-incubator/spartakus/pull/13:
@@ -89,7 +88,6 @@ func (s *APIServer) storeRecordHandler() httprouter.Handle { writeError(w, http.StatusBadRequest, fmt.Errorf("failed to decode record: %v", err)) return }
- rec.Timestamp = strconv.FormatInt(time.Now().Unix(), 10)
what do you mean by sanity?
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/kubernetes-incubator/spartakus/pull/13, or mute the thread https://github.com/notifications/unsubscribe-auth/AFVgVO3lGCGaJJBL1fJ2B7iWADjY3yvhks5rDlU6gaJpZM4K6HnB .
Currently, the
timestamp
field is only added to reports that are processed with a Spartakus collector. If you run the volunteer with--database=stdout
or even--database=bigquery://...
your records will have no timestamp. This commit adds the timestamp field to reports at the time of creation in the volunteer.