kubernetes-retired / spartakus

[EOL] Anonymous Usage Collector
Apache License 2.0
74 stars 30 forks source link

report: add cloud provider name to report #17

Closed squat closed 7 years ago

squat commented 7 years ago

This commit modifies the Node struct and adds a new field CloudProvider. This value is determined by taking the <ProviderName> portion of the ProviderID reported in the node spec. Making this change will require updating the database schema. The cloud provider name is checked against a whitelist of know cloud providers to avoid leaking any PII.

This PR re-opens the discussion from #15 with the discussed whitelist.

thockin commented 7 years ago

LGTM. I'll make the schema change

thockin commented 7 years ago

I added the schema file in pkg/database