search

kubernetes-sigs / apiserver-network-proxy

Apache License 2.0
381 stars 182 forks source link

Fix 'kind' example manifests. #607

Closed jkh52 closed 7 months ago

jkh52 commented 7 months ago

I tried the instructions at https://github.com/kubernetes-sigs/apiserver-network-proxy/tree/master/examples/kind, but they have regressed and needed fixing.

For the image name change, it's clear that https://github.com/kubernetes-sigs/apiserver-network-proxy/pull/579 inadvertently broke the examples/kind/README.md workflow.

For the runAsUser: 0 server change, it's a bit mysterious, but I get crashlooping without it. It is possible that https://github.com/kubernetes-sigs/apiserver-network-proxy/pull/564 explains the regression, but I haven't verified carefully.

jkh52 commented 7 months ago

/assign @tallclair

cheftako commented 7 months ago

/lgtm /approve

k8s-ci-robot commented 7 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheftako, jkh52

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/apiserver-network-proxy/blob/master/OWNERS)~~ [cheftako,jkh52] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment