search

kubernetes-sigs / apiserver-network-proxy

Apache License 2.0
381 stars 182 forks source link

CVE-2023-45288 (release-0.30): update golang.org/x/net to 1.23.0 #614

Closed avrittrohwer closed 6 months ago

avrittrohwer commented 6 months ago

Copy of https://github.com/kubernetes-sigs/apiserver-network-proxy/pull/613

Ran:

go get -u golang.org/x/net@v0.23.0
go mod tidy
go mod vendor
k8s-ci-robot commented 6 months ago

Hi @avrittrohwer. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
jkh52 commented 6 months ago

/ok-to-test

jkh52 commented 6 months ago

/lgtm /approve

avrittrohwer commented 6 months ago

/retest

avrittrohwer commented 6 months ago

/test

k8s-ci-robot commented 6 months ago

@avrittrohwer: The /test command needs one or more targets. The following commands are available to trigger required jobs:

Use /test all to run all jobs.

In response to [this](https://github.com/kubernetes-sigs/apiserver-network-proxy/pull/614#issuecomment-2073540641): >/test Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
jkh52 commented 6 months ago

make-lint-0-30 appears hung. I think it will timeout after 4h, until then I'm not sure how to retry it.

avrittrohwer commented 6 months ago

/test pull-apiserver-network-proxy-make-lint-0-30

jkh52 commented 6 months ago

@liangyuanpeng lint seems to hang. I wonder if there's something broken, involving the linter runaway execution on the vendor/ directory... but, a recent PR in master branch did not seem to have the issue.

jkh52 commented 6 months ago

@avrittrohwer can you try adding this to .golangci.yaml in this PR:

run:
  skip-dirs:
    - vendor
avrittrohwer commented 6 months ago

/retest

avritt-techx commented 6 months ago

/test pull-apiserver-network-proxy-make-lint-0-30

jkh52 commented 6 months ago

@avrittrohwer can you try adding this to .golangci.yaml in this PR:

run:
  skip-dirs:
    - vendor

nevermind I think the relevant fix is https://github.com/kubernetes-sigs/apiserver-network-proxy/pull/617

liangyuanpeng commented 6 months ago

@liangyuanpeng lint seems to hang.

Sorry for my late, i can not see the @ message from this repo, have not found the reason yet.

cheftako commented 6 months ago

/lgtm /approve

k8s-ci-robot commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avrittrohwer, cheftako, jkh52

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/apiserver-network-proxy/blob/release-0.30/OWNERS)~~ [cheftako,jkh52] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
cheftako commented 6 months ago

/retest pull-apiserver-network-proxy-make-lint-0-30

k8s-ci-robot commented 6 months ago

@cheftako: The /retest command does not accept any targets. The following commands are available to trigger required jobs:

Use /test all to run all jobs.

In response to [this](https://github.com/kubernetes-sigs/apiserver-network-proxy/pull/614#issuecomment-2079776046): >/retest pull-apiserver-network-proxy-make-lint-0-30 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
cheftako commented 6 months ago

/test pull-apiserver-network-proxy-make-lint-0-30