search

kubernetes-sigs / apisnoop

⭕️Snooping on the Kubernetes OpenAPI communications
https://apisnoop.cncf.io
Apache License 2.0
87 stars 42 forks source link

fix: check pending eligible endpoints #861

Closed heyste closed 5 months ago

heyste commented 6 months ago

Currently https://testgrid.k8s.io/sig-arch-conformance#apisnoop-conformance-gate fails with 

==================
UNTESTED ENDPOINTS
getStoragemigrationAPIGroup
==================
ERROR: You have 1 untested endpoints
==================

This fix filters out any pending eligible endpoints from the list of untested endpoints which should produce the following result

==================
UNTESTED ENDPOINTS

==================
You have 0 untested endpoints
==================
k8s-ci-robot commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: heyste

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/apisnoop/blob/main/OWNERS)~~ [heyste] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
netlify[bot] commented 6 months ago

Deploy Preview for apisnoop canceled.

Name Link
Latest commit c35f7705638a771d38acc2bfdb0c01263373f9c3
Latest deploy log https://app.netlify.com/sites/apisnoop/deploys/660e03b75c979200089f358f
hh commented 5 months ago

Temporary work around while fixing a job. /close

k8s-ci-robot commented 5 months ago

@hh: Closed this PR.

In response to [this](https://github.com/kubernetes-sigs/apisnoop/pull/861#issuecomment-2050578085): >Temporary work around while fixing a job. >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.