search

kubernetes-sigs / apisnoop

⭕️Snooping on the Kubernetes OpenAPI communications
https://apisnoop.cncf.io
Apache License 2.0
88 stars 42 forks source link

Remove --kube-root deprecated kind argument #902

Closed stmcginnis closed 3 months ago

stmcginnis commented 3 months ago

The --kube-root flag has been deprecated in kind for some time and will be removed. The current equivalent functionality is to pass the path to the kubernetes source as the first non-flag argument to build node-image.

This updates the kind instructions to use the newer preferred method in preparation for kind dropping the flag.

Related: https://github.com/kubernetes-sigs/kind/issues/3717

netlify[bot] commented 3 months ago

Deploy Preview for apisnoop canceled.

Name Link
Latest commit 05e9fcd5d0bc867de35e729b40790eec4d60a193
Latest deploy log https://app.netlify.com/sites/apisnoop/deploys/66c4afe58178fd000868fca5
heyste commented 3 months ago

@stmcginnis Thanks for the pr

/lgtm /approve

k8s-ci-robot commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: heyste, stmcginnis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/apisnoop/blob/main/OWNERS)~~ [heyste] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment