search

kubernetes-sigs / application

Application metadata descriptor CRD
Apache License 2.0
513 stars 167 forks source link

Adding release scripts #187

Closed barney-s closed 4 years ago

barney-s commented 4 years ago

Adding release targets in makefile. Simplifying the generation part.

The goal is the aio file would be unique for each release branch.

k8s-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: barney-s

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/application/blob/master/OWNERS)~~ [barney-s] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
barney-s commented 4 years ago

/assign @ant31

Please review @nan-yu

barney-s commented 4 years ago

For #166

barney-s commented 4 years ago

@ant31 - Would you be able to review and LGTM this ? @mortent - This is required to generate an official release branch. Would you please review this ?

Also the current version is being pinned at an arbitrary 0.8.1 Any suggestions ?

ant31 commented 4 years ago

I would tend to prioritize end-user experience and make 'deploy' target not directly using the pre-generated aio file (use default VERSION file too). It removes the need to download all binaries and development dependencies. Maintainers would take extra steps anyway and dive more in the configuration

Is the aoi file published in github releases?

barney-s commented 4 years ago

Is the aoi file published in github releases?

Yes. deploy/kube-app-manager-aio.yaml for each branch/tag