Update to Kubernetes v1.18.2

[tamalsaha]

Signed-off-by: Tamal Saha tamal@appscode.com

[k8s-ci-robot]

Welcome @tamalsaha!

It looks like this is your first PR to kubernetes-sigs/application 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/application has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tamalsaha To complete the pull request process, please assign mattfarina You can assign the PR to them by writing /assign @mattfarina in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-sigs/application/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

[tamalsaha]

@nan-yu, can you please help me fix these test failures. We would like to see client-go updated to v1.18.x .

[fejta-bot]

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

[nan-yu]

Nan Yu, can you please help me fix these test failures. We would like to see client-go updated to v1.18.x .

There're a couple of issues need to be fixed. I addressed them in my fork: https://github.com/nan-yu/application/commit/fb9cca9591b38f83e6fab8b960dc734c911147d8. Please take a look.

Here is the summary:

• merge app.k8s.io_applications.yaml with app.k8s.io_applications.v1.yaml to get rid of the v1beta1 version of CRD
• replace the deprecated apiextensions.k8s.io/v1beta1 version with apiextensions.k8s.io/v1beta1
• add kubectl to the PATH as the latest controller-gen depends on kubectl
• remove kind get kubeconfig-path --name="kind" as kubeconfig-path was depracated in kind v0.8.1
• delete an empty file
• update customerreource.go to use the v1 API instead of v1beta1 add license to the generated resources
• remove the extra type field from the test application.yaml file
• add the version field to the test GVK

And a successful travis build: https://travis-ci.com/github/nan-yu/application/builds/189108875

@tamalsaha ^^

[tamalsaha]

Thanks @nan-yu ! If you want to open a pr, you are most welcome. I can close this one in that case.

[nan-yu]

Thanks Nan Yu ! If you want to open a pr, you are most welcome. I can close this one in that case.

Sure. The fixes, along with your original changes, are in https://github.com/kubernetes-sigs/application/pull/207. Thanks again for the update!