search

kubernetes-sigs / application

Application metadata descriptor CRD
Apache License 2.0
513 stars 167 forks source link

fix deployment status condition #208

Closed zackzhangkai closed 4 years ago

zackzhangkai commented 4 years ago

the deployment status condition should be "ReplicaSetUpdated" instead of "NewReplicaSetAvailable"

k8s-ci-robot commented 4 years ago

Welcome @zackzhangkai!

It looks like this is your first PR to kubernetes-sigs/application 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/application has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zackzhangkai To complete the pull request process, please assign janetkuo after the PR has been reviewed. You can assign the PR to them by writing /assign @janetkuo in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-sigs/application/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment