kubernetes-sigs / aws-ebs-csi-driver

CSI driver for Amazon EBS https://aws.amazon.com/ebs/
Apache License 2.0
981 stars 792 forks source link

Add relabelings stanza for ServiceMonitor #1724

Open xadcoh opened 1 year ago

xadcoh commented 1 year ago

Is your feature request related to a problem?/Why is this needed I'd like to enrich metrics with additional labels

/feature

Describe the solution you'd like in detail In Helm Chart in metrics.yaml modify endpoints:

spec:
  ...
  endpoints:
    - targetPort: 3301
      path: /metrics
      interval: 15s
      {{- if .Values.controller.serviceMonitor.extraRelabelings }}
      relabelings:
      {{- toYaml .Values.controller.serviceMonitor.extraRelabelings | nindent 6 }}
      {{- end }}

Describe alternatives you've considered None

Additional context None

r2ronoha commented 11 months ago

This would be great. We are currently having to either patch or override the ServiceMonitor in our infrastructure to be able to add relablings that we need

k8s-triage-robot commented 8 months ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot commented 7 months ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

AndrewSirenko commented 7 months ago

/remove-lifecycle rotten

k8s-triage-robot commented 4 months ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

r2ronoha commented 4 months ago

/remove-lifecycle rotten

k8s-triage-robot commented 3 months ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

AndrewSirenko commented 3 months ago

/remove-lifecycle rotten

k8s-triage-robot commented 5 days ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale