Closed ConnorJC3 closed 1 month ago
File | Old Coverage | New Coverage | Delta |
---|---|---|---|
github.com/kubernetes-sigs/aws-ebs-csi-driver/pkg/cloud/metadata/ec2.go | 94.4% | 94.3% | -0.1 |
github.com/kubernetes-sigs/aws-ebs-csi-driver/pkg/cloud/metadata/metadata.go | 96.7% | 97.0% | 0.3 |
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: torredil
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/retest
Is this a bug fix or adding new feature?
Bug fix
What is this PR about? / Why do we need it?
The current logging for metadata is extremely misleading and (in some cases) straight up wrong. This PR fixes that (and a few other related issues) by:
main.go
and use clear and specific log messagesAWS_REGION
innode.go
- it's already logged inmain.go
and always logging it there (with a confusing variable name likeregionFromSession
) is misleadingAWS_REGION
if present, even in the node serviceWhat testing is done?
Manual/CI/Updated unit tests
Examples of new output: