search

kubernetes-sigs / aws-ebs-csi-driver

CSI driver for Amazon EBS https://aws.amazon.com/ebs/
Apache License 2.0
940 stars 774 forks source link

add namespaceOverride support #2052

Closed RuStyC0der closed 3 weeks ago

RuStyC0der commented 3 weeks ago

PR regarding issue #2050

linux-foundation-easycla[bot] commented 3 weeks ago

CLA Signed

The committers listed above are authorized under a signed CLA.

k8s-ci-robot commented 3 weeks ago

Welcome @RuStyC0der!

It looks like this is your first PR to kubernetes-sigs/aws-ebs-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-ebs-csi-driver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot commented 3 weeks ago

Hi @RuStyC0der. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
torredil commented 3 weeks ago

/ok-to-test

github-actions[bot] commented 3 weeks ago

Code Coverage Diff

This PR does not change the code coverage

rdpsin commented 3 weeks ago

Can you squash your commits into one? Thanks.

AndrewSirenko commented 3 weeks ago

/label tide/merge-method-squash

Can you squash your commits into one?

Prow got some upgrades @rdpsin 😄

ConnorJC3 commented 3 weeks ago

Unfortunately, you will need to rebase on top of the latest master to make govulncheck happy - once you do that we can merge this in.

RuStyC0der commented 3 weeks ago

Hi @ConnorJC3, just rebased master commits)

RuStyC0der commented 3 weeks ago

/test pull-aws-ebs-csi-driver-external-test-arm64

AndrewSirenko commented 3 weeks ago

/lgtm

RuStyC0der commented 3 weeks ago

Hi, if there is no more issues, shall we get this PR merged?

ConnorJC3 commented 3 weeks ago

/approve

k8s-ci-robot commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ConnorJC3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/aws-ebs-csi-driver/blob/master/OWNERS)~~ [ConnorJC3] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
RuStyC0der commented 3 weeks ago

Thank all you guys for reviewing this PR) Hope my small enhancement will be useful)