search

kubernetes-sigs / aws-ebs-csi-driver

CSI driver for Amazon EBS https://aws.amazon.com/ebs/
Apache License 2.0
940 stars 774 forks source link

csi-node-driver-registrar logs in json format #2070

Closed gmarcot closed 2 days ago

gmarcot commented 1 week ago

Hey folks,

i ask to you if possible add the option to choose the logs format ( text , json ) for the csi-node-driver-registrar

Thanks

torredil commented 1 week ago

Hey there @gmarcot , this feature will be supported in our upcoming monthly driver release v1.32.0 which includes the latest node-driver-registrar version (v2.11.0). Once the release is published, you may configure the log format by specifying logging-format via the sidecars.nodeDriverRegistrar.additionalArgs Helm parameter:

nodeDriverRegistrar:
  additionalArgs:
    - "--logging-format=json"

example JSON log output:

{"ts":1719254704626.5413,"caller":"csi-node-driver-registrar/main.go:150","msg":"Version","v":0,"version":"v2.11.0"}
{"ts":1719254704626.5776,"caller":"csi-node-driver-registrar/main.go:151","msg":"Running node-driver-registrar","v":0,"mode":""}
...

For more information see node driver registrar release notes: https://github.com/kubernetes-csi/node-driver-registrar/blob/release-2.11/CHANGELOG/CHANGELOG-2.11.md#release-notes-for-v2110 and relevant PR https://github.com/kubernetes-csi/node-driver-registrar/pull/349

gmarcot commented 1 week ago

Good morning @torredil

many thanks for your replay, very good notice for me, great works

many thanks

torredil commented 2 days ago

This request has been addressed in driver release v1.32.0. /close

k8s-ci-robot commented 2 days ago

@torredil: Closing this issue.

In response to [this](https://github.com/kubernetes-sigs/aws-ebs-csi-driver/issues/2070#issuecomment-2200107587): >This request has been addressed in driver release `v1.32.0`. >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.