kubernetes-sigs / aws-ebs-csi-driver

CSI driver for Amazon EBS https://aws.amazon.com/ebs/
Apache License 2.0
993 stars 797 forks source link

Add fix for enableLinux node parameter #2078

Closed ElijahQuinones closed 4 months ago

ElijahQuinones commented 4 months ago

Is this a bug fix or adding new feature? This is a bug fix What is this PR about? / Why do we need it? Previously the parameter enableLinux did not work because it was set to true regardless of what you pass in as a parameter What testing is done? I deployed my dev cluster with the change and ran the following command to install the driver with enableLinux set to false

helm upgrade \
  --install aws-ebs-csi-driver \
  --namespace kube-system \
  ./charts/aws-ebs-csi-driver \
  --set controller.replicaCount=1 \
  --set image.pullPolicy=Always \
  --set controller.logLevel=7 \
  --set image.repository="533267024531.dkr.ecr.us-west-2.amazonaws.com/aws-ebs-csi-driver"\
  --set image.tag="TEST-ELIJAH-linux-amd64-al2023" \
--set node.enableLinux="false"

I then ran kubectl -n kube-system get daemonset.apps with the following output

NAME                           DESIRED   CURRENT   READY   UP-TO-DATE   AVAILABLE   NODE SELECTOR   AGE
aws-cloud-controller-manager   1         1         1       1            1           <none>          48m
cilium                         4         4         4       4            4           <none>          48m
kops-controller                1         1         1       1            1           <none>          48m

Finally i ran the same helm command but with enableLinux set to true and got the following output.

helm upgrade \
  --install aws-ebs-csi-driver \
  --namespace kube-system \
  ./charts/aws-ebs-csi-driver \
  --set controller.replicaCount=1 \
  --set image.pullPolicy=Always \
  --set controller.logLevel=7 \
  --set image.repository="533267024531.dkr.ecr.us-west-2.amazonaws.com/aws-ebs-csi-driver"\
  --set image.tag="TEST-ELIJAH-linux-amd64-al2023" \
--set node.enableLinux="true"

 kubectl -n kube-system get daemonset.apps
NAME                           DESIRED   CURRENT   READY   UP-TO-DATE   AVAILABLE   NODE SELECTOR            AGE
aws-cloud-controller-manager   1         1         1       1            1           <none>                   49m
cilium                         4         4         4       4            4           <none>                   49m
ebs-csi-node                   4         4         4       4            4           kubernetes.io/os=linux   5s
kops-controller                1         1         1       1            1           <none>                   49m

Additionally I ran make update && make verify && make test

k8s-ci-robot commented 4 months ago

Hi @ElijahQuinones. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
ConnorJC3 commented 4 months ago

/ok-to-test

github-actions[bot] commented 4 months ago

Code Coverage Diff

This PR does not change the code coverage

torredil commented 4 months ago

/retest

torredil commented 4 months ago

/approve

k8s-ci-robot commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: torredil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/aws-ebs-csi-driver/blob/master/OWNERS)~~ [torredil] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment