Closed ElijahQuinones closed 4 months ago
Hi @ElijahQuinones. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
/ok-to-test
This PR does not change the code coverage
/retest
/approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: torredil
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Is this a bug fix or adding new feature? This is a bug fix What is this PR about? / Why do we need it? Previously the parameter enableLinux did not work because it was set to true regardless of what you pass in as a parameter What testing is done? I deployed my dev cluster with the change and ran the following command to install the driver with enableLinux set to false
I then ran
kubectl -n kube-system get daemonset.apps with the following output
Finally i ran the same helm command but with enableLinux set to true and got the following output.
Additionally I ran
make update && make verify && make test