search

kubernetes-sigs / aws-ebs-csi-driver

CSI driver for Amazon EBS https://aws.amazon.com/ebs/
Apache License 2.0
993 stars 797 forks source link

Change coalescer InputType from `comparable` to `any` #2083

Closed ConnorJC3 closed 4 months ago

ConnorJC3 commented 4 months ago

Is this a bug fix or adding new feature?

Bug fix (internal facing, not customer facing)

What is this PR about? / Why do we need it?

InputType in the coalescer shouldn't be comparable as we don't use it as a key anywhere. Requiring it to be comparable breaks coalescing with types that are not comparable such as maps, slices, etc. (for example see PR #2082 where it had to be added as a pointer instead of a map directly).

What testing is done?

CI

github-actions[bot] commented 4 months ago

Code Coverage Diff

This PR does not change the code coverage

k8s-ci-robot commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: torredil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/aws-ebs-csi-driver/blob/master/OWNERS)~~ [torredil] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ConnorJC3 commented 4 months ago

/retest

is a flake