Closed cHiv0rz closed 4 months ago
Hi @cHiv0rz. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
@AndrewSirenko is anything pending from my side?
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: ConnorJC3
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Is this a bug fix or adding new feature? bug fix
What is this PR about? / Why do we need it? Fix the indentation of
dnsConfig
option in controller.yaml. It should be at the same level oftemplate.spec.containers
, but before this change, it was astemplate.spec
level.What testing is done? edit the values.yml and set a custom configuration, iE:
The manifest you get from the previous is:
but instead should be: