search

kubernetes-sigs / aws-ebs-csi-driver

CSI driver for Amazon EBS https://aws.amazon.com/ebs/
Apache License 2.0
974 stars 787 forks source link

Migrate CreateVolume response topology to standard label topology.kubernetes.io/zone #2086

Closed ConnorJC3 closed 2 months ago

ConnorJC3 commented 2 months ago

*Is this a bug fix or adding new feature?**

Feature

What is this PR about? / Why do we need it?

See https://github.com/kubernetes-sigs/aws-ebs-csi-driver/issues/729#issuecomment-1942026577

What testing is done?

CI/Manual

github-actions[bot] commented 2 months ago

Code Coverage Diff

This PR does not change the code coverage

ConnorJC3 commented 2 months ago

the flake experience /retest

ConnorJC3 commented 2 months ago

/retest

Is flake, might need to up the tolerances on that test, seeing it flake more often recently

k8s-ci-robot commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: torredil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/aws-ebs-csi-driver/blob/master/OWNERS)~~ [torredil] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
torredil commented 2 months ago

/hold

AndrewSirenko commented 2 months ago

/unhold