search

kubernetes-sigs / aws-ebs-csi-driver

CSI driver for Amazon EBS https://aws.amazon.com/ebs/
Apache License 2.0
993 stars 797 forks source link

Supporting String Interpolation for Modifying Tags On Existing Volumes Through VAC #2093

Open mdzraf opened 4 months ago

mdzraf commented 4 months ago

Is this a bug fix or adding new feature?

New feature

What is this PR about? / Why do we need it?

This will add the support for runtime string interpolation on tag values for a volume upon modification, which allows for customers to specify placeholder values for the PVC namespace, PVC name and PV name, which will then be dynamically computed at runtime.

What testing is done?

Unit tests were ran to ensure that input was parsed properly and manual testing was done after initial changes to external-resizer sidecar code were made to pass in the extra metadata necessary to the driver and ensuring that these tags were properly added at runtime.

k8s-ci-robot commented 4 months ago

Hi @mdzraf. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
ConnorJC3 commented 3 months ago

/ok-to-test

github-actions[bot] commented 3 months ago

Code Coverage Diff

File Old Coverage New Coverage Delta
github.com/kubernetes-sigs/aws-ebs-csi-driver/pkg/driver/controller_modify_volume.go 78.3% 79.8% 1.5
mdzraf commented 3 months ago

/hold

mdzraf commented 3 months ago

/retest

mdzraf commented 3 months ago

/retest

AndrewSirenko commented 3 months ago

/lgtm

k8s-ci-robot commented 3 months ago

New changes are detected. LGTM label has been removed.

k8s-ci-robot commented 3 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from andrewsirenko. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-sigs/aws-ebs-csi-driver/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
mdzraf commented 3 months ago

/retest

mdzraf commented 2 months ago

/retest

k8s-ci-robot commented 2 weeks ago

PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.