fix: sidecars.snapshotter.logLevel not being respect

kubernetes-sigs / aws-ebs-csi-driver

CSI driver for Amazon EBS https://aws.amazon.com/ebs/

Apache License 2.0

998 stars 800 forks source link

fix: sidecars.snapshotter.logLevel not being respect #2102

Closed zyue110026 closed 4 months ago

zyue110026 commented 4 months ago

Is this a bug fix or adding new feature? bug fix #2101 What is this PR about? / Why do we need it? sidecars.snapshotter.logLevel does not take affect when change the log level in values.yaml. What testing is done?

linux-foundation-easycla[bot] commented 4 months ago

The committers listed above are authorized under a signed CLA.

:white_check_mark: login: zyue110026 (10139f5d35f81ae53a81dda18fc51bca408a2b8d)

k8s-ci-robot commented 4 months ago

Welcome @zyue110026!

It looks like this is your first PR to kubernetes-sigs/aws-ebs-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-ebs-csi-driver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot commented 4 months ago

Hi @zyue110026. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

AndrewSirenko commented 4 months ago

/ok-to-test

torredil commented 4 months ago

/retest

ConnorJC3 commented 4 months ago

Single AZ failure is unrelated and seems to be due to some k8s CI issue:

 #1 ERROR: Error response from daemon: failed to create task for container: failed to create shim task: OCI runtime create failed: runc create failed: no space left on device: unknown

The verify failure is real - @zyue110026 please run make update and squash the changes into your existing PR.

github-actions[bot] commented 4 months ago

Code Coverage Diff

This PR does not change the code coverage

zyue110026 commented 4 months ago

@ConnorJC3 Hi, I run make update but get following error, what should I do?

gofmt -s -w .
/usr/bin/python3
tar: Option --touch is not supported
Usage:
  List:    tar -tf <archive-filename>
  Extract: tar -xf <archive-filename>
  Create:  tar -cf <archive-filename> [filenames...]
  Help:    tar --help
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0 15.0M    0 32768    0     0  35042      0  0:07:29 --:--:--  0:07:29 35083
curl: (23) Failure writing output

ConnorJC3 commented 4 months ago

I think that's because you're running on MacOS which our Makefile doesn't support. I've gone ahead and updated your PR myself with the relevant auto-generated changes.

ConnorJC3 commented 4 months ago

/approve

k8s-ci-robot commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ConnorJC3, torredil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/aws-ebs-csi-driver/blob/master/OWNERS)~~ [ConnorJC3,torredil] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment