search

kubernetes-sigs / aws-ebs-csi-driver

CSI driver for Amazon EBS https://aws.amazon.com/ebs/
Apache License 2.0
993 stars 797 forks source link

Ensure ModifyVolume returns InvalidArgument error code if VAC contains invalid parameter #2103

Closed mdzraf closed 3 months ago

mdzraf commented 3 months ago

Is this a bug fix or adding new feature? Bug fix

What is this PR about? / Why do we need it? Closes #2099

What testing is done? Manual testing was done to verify that volume modification does not succeed and error is returned if non-supported parameter is inputted in VAC

k8s-ci-robot commented 3 months ago

Hi @mdzraf. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
ConnorJC3 commented 3 months ago

/ok-to-test

github-actions[bot] commented 3 months ago

Code Coverage Diff

File Old Coverage New Coverage Delta
github.com/kubernetes-sigs/aws-ebs-csi-driver/pkg/cloud/devicemanager/allocator.go 93.3% 100.0% 6.7
github.com/kubernetes-sigs/aws-ebs-csi-driver/pkg/driver/controller_modify_volume.go 72.0% 72.3% 0.3
ConnorJC3 commented 3 months ago

/approve

mdzraf commented 3 months ago

/retest

ConnorJC3 commented 3 months ago

/label tide/merge-method-squash

torredil commented 3 months ago

/remove-lgtm

mdzraf commented 3 months ago

/retest

k8s-ci-robot commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ConnorJC3, torredil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/aws-ebs-csi-driver/blob/master/OWNERS)~~ [ConnorJC3,torredil] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment